search

uber-archive / cherami-server

Distributed, scalable, durable, and highly available message queue system. This project is deprecated and not maintained.
https://eng.uber.com/cherami/
MIT License
1.42k stars 102 forks source link

Cannot get StatsD Metrics #331

Closed doodle-tnw closed 6 years ago

doodle-tnw commented 6 years ago

I've noticed that Cherami supports sending stats to a statsd server. From looking through the code i have the following configuration:

DefaultServiceConfig:
  ListenAddress: "..."
  RingHosts: "..."
  EnableLimits: true
  Metrics:
    statsd:
      hostPort: "statsd:8125"
      prefix: "ch"

And I can see a RuntimeMetricsReporter starts, but because the statsd metrics exporters doesn't log anywhere I can't see why I'm not getting stats appear on the other end. is there a configuration I have missed?

Cheers, Dan

doodle-tnw commented 6 years ago

Ah,

It looks like it doesn't use the values from the DefaultServiceConfig - metrics have to be added to each host.

@datoug - Is this the desired implementation? Or should it attempt to merge in the metrics config into the service config if its not supplied? Most/all my hosts will be using the same metrics configuration - seems pointless duplicating it so many times.

Cheers, Dan