Fix length check. - Githubissues

uber-archive / cherami-server

Distributed, scalable, durable, and highly available message queue system. This project is deprecated and not maintained.

https://eng.uber.com/cherami/

MIT License

1.42k stars 102 forks source link

Fix length check. #352

Closed xiemaisi closed 5 years ago

xiemaisi commented 5 years ago

The length of an array is never negative, so the condition as written can never hold.

coveralls commented 5 years ago

Coverage increased (+0.4%) to 66.884% when pulling 1737a73685e5cfcb57dafddd146c24acb4c7ed0a on xiemaisi:negative-length into 1de31a4ed1d0a9cd33ff64199f7e91f23e99c11e on uber:master.

xiemaisi commented 5 years ago

Is there anything I should do to expedite review of this PR? (The CI failure looks unrelated.)