search

uber-archive / hyperbahn

Service discovery and routing for large scale microservice operations
MIT License
395 stars 57 forks source link

Log `willSample` prepublish replacer #211

Open rf opened 8 years ago

rf commented 8 years ago

This requires an updated larch so it isn't ready to land yet, but it works.

Wrote a simple script to insert willSample checks before log lines. I messed around with using some macro systems (sweet.js and the C preprocessor) but found that neither would work. The replacer script is an inelegant solution but it's short and it works.

r: @raynos @jcorbin

Raynos commented 8 years ago

This seems reasonable.

I want to try running it and looking at a diff of the pre-process vs post-process.

Also we need to figure out what to do in terms of workflow, prepublish might have to copy into a "build/*" folder and we should change the package.json to import from there.

Then we can .gitignore build/*

Raynos commented 8 years ago

tests fail lal.

rf commented 8 years ago

Changed this to use publish.sh. It's real ugly but it runs the replacer, makes a temp commit, creates the package, then resets git.

Raynos commented 8 years ago

we need to fix debug logtron.