uber-archive / hyperbahn

Service discovery and routing for large scale microservice operations
MIT License
395 stars 57 forks source link

Further simplify circuit state change observation #228

Closed jcorbin closed 8 years ago

jcorbin commented 8 years ago

NOTE: since we no longer involve serviceProxy.extendLogInfo or channel.extendLogInfo, the following log fields have been removed from circuit state change logs:

info.affineServices         = Object.keys(self.exitServices);
info.channelDestroyed       = self.destroyed;
info.channelDraining        = self.draining;
info.channelListened        = self.listened;
info.channelListening       = self.listening;
info.circuitsEnabled        = self.circuitsEnabled;
info.hostPort               = self.hostPort;
info.minPeersPerRelay       = self.minPeersPerRelay;
info.minPeersPerWorker      = self.minPeersPerWorker;
info.partialAffinityEnabled = self.partialAffinityEnabled;
info.rateLimiterEnabled     = self.rateLimiterEnabled;

I think this is okay and that we don't need these fields, reviewers please double check.

r @raynos @kriskowal @rf

kriskowal commented 8 years ago

The lost log fields are okay.

kriskowal commented 8 years ago

:ok: