Ensure correctness in unadvertise test

uber-archive / hyperbahn

Service discovery and routing for large scale microservice operations

MIT License

395 stars 57 forks source link

Ensure correctness in unadvertise test #231

Closed jcorbin closed 8 years ago

jcorbin commented 8 years ago

Previously this test didn't handle well the case where there weren't any connections to be closed, due to tacitly assuming that connections get opened immediately.

Furthermore it wasn't straightforward to fix this as we were previously depending on the non-immediate callback of untilAllInConnsRemoved to actually wait for the unadvertise RPC to finish, rather than actually fencing on its callback.

r @kriskowal @rf

kriskowal commented 8 years ago

:ok:

rf commented 8 years ago

:+1: