search

uber-archive / hyperbahn

Service discovery and routing for large scale microservice operations
MIT License
396 stars 57 forks source link

Do incremental work under ServiceProxy#removeServicePeer #259

Closed jcorbin closed 8 years ago

jcorbin commented 8 years ago

Use partialRange.removeWorker rather than sorting all service workers.

jcorbin commented 8 years ago

Going to block and rebase on https://github.com/uber/hyperbahn/pull/250 since it adds more coverage to the affected path.

Raynos commented 8 years ago

I trust the method does what it says on the tin.

jcorbin commented 8 years ago

it does, and it's already used by the other way that we remove workers under the peer reaper: https://github.com/uber/hyperbahn/blob/master/service-proxy.js#L1471

jcorbin commented 8 years ago

Amusingly enough, this method did not work as advertised; fixed in #267.