Closed jacobp100 closed 9 years ago
Can we add a test case for this comment? Maybe we should break out the extraction method so we can test it more independently (i.e. without needing an image)
Do you want a test with two images that are so similar to cause this scenario?
Nah, I imagine that would require very large images to be stored in the repo. We should relocate the .match
into its own function so it can be tested independently
It’s certainly possible to add these tests. Although Imagemagick is pretty bad for maintaining compatibility, so it might not be the best use of time.
Yea, but this will also put us in a more flexible state for the future. I am going to open a secondary PR to add that functionality. This PR looks good for now.
I have opened up #30 which brings this PR over the finish line and ready for landing.
Sorry for the delay. Thanks!
Woot, thanks @mlmorg =)
From error,