search

uber-archive / image-diff

Create image differential between two images
MIT License
2.46k stars 94 forks source link

Some Image Differences Cause Crash #31

Closed jacobp100 closed 9 years ago

jacobp100 commented 9 years ago 
! Exception ocurred when performing image diff for tiedChords-ipad-pro-portrait@1-p1
[Error: Expected `image-diff's stderr` to contain 'all' but received "/tmp/tmp-76818mswa0g.png PNG 1024x1366 1024x1366+0+0 8-bit DirectClass 14.2KB 0.010u 0:00.019
/tmp/tmp-76818m6035c.png PNG 1024x1366 1024x1366+0+0 8-bit DirectClass 14.2KB 0.010u 0:00.019
Image: /tmp/tmp-76818mswa0g.png
  Channel distortion: RMSE
    gray: 0.532272 (8.12195e-06)
    alpha: 0 (0)
    all: 0.460961 (7.03381e-06)
/tmp/tmp-76818mswa0g.png=>artifacts/diff/features/tie/tiedChords-ipad-pro-portrait@1-p1.png PNG 1024x1366 1024x1366+0+0 8-bit PseudoClass 3c 0.150u 0:00.149
"]

See https://github.com/uber/image-diff/pull/29

twolfson commented 9 years ago

Why did you open a duplicate issue for this? Please close it =/

jacobp100 commented 9 years ago

The other is a PR. This is to track the issue.

twolfson commented 9 years ago

Every repo does this differently -- for me, I think a PR can be considered as an issue tracker. This one can be closed =/