uber-archive / lint-trap

JavaScript linter module for Uber projects
26 stars 2 forks source link

Get *.js indentation from .editorconfig file #88

Closed andrewdeandrade closed 9 years ago

andrewdeandrade commented 9 years ago

Fixes: https://github.com/uber/lint-trap/issues/39

Once this is accepted, I'll cut 0.5.0 (breaking api change since you need an .editorconfig file). Let me know if I should make editorconfig optional. My gut is no since .editorconfig does a lot to help multiple people working on the same project.

cc: @raynos

Raynos commented 9 years ago

@malandrew

Semver is not optional. if you make a breaking change you got 1.0.

In fact, the fact that you have any project that is <1.0 is silly, all modules should start at v1 or v2 out of the gate.

If you have some sort of emotional attachment to version "1.0" then forget that. Communicating with your users is always more important.

Raynos commented 9 years ago

Please ship with a default editorconfig in the rc folder.

andrewdeandrade commented 9 years ago

Got it.

Todo:

andrewdeandrade commented 9 years ago

@Raynos

Let me know if this is okay now.

andrewdeandrade commented 9 years ago

Since I'm going to cut a 1.0.0 for this, I'm also resolving these issues:

andrewdeandrade commented 9 years ago

Resolving https://github.com/uber/lint-trap/issues/76

Raynos commented 9 years ago

lgtm.