removed panics that mess up in k8s environments that use a random UID

uber-archive / makisu

Fast and flexible Docker image building tool, works in unprivileged containerized environments like Mesos and Kubernetes.

Apache License 2.0

2.41k stars 153 forks source link

removed panics that mess up in k8s environments that use a random UID #141

Closed nnordrum closed 5 years ago

nnordrum commented 5 years ago

I agree 100% with everything you said in #133 in theory, but you're not actually using the names, and other corporate environments have a different CI/CD setup than you do. What I've changed it to meets the MVP of the functions, passes all known tests, and works in kubernetes without having to play wack-a-mole to get user.Current() to work.

CLAassistant commented 5 years ago

All committers have signed the CLA.

yiranwang52 commented 5 years ago

I see. Thanks for the fix.