uber-archive / makisu

Fast and flexible Docker image building tool, works in unprivileged containerized environments like Mesos and Kubernetes.
Apache License 2.0
2.41k stars 154 forks source link

Remove setting SSL_CERT_DIR in Makisu Dockerfile #172

Closed evelynl94 closed 5 years ago

evelynl94 commented 5 years ago

set default SSL_CERT_DIR in Dockerfile changes the default cert directory from /etc/ssl/certs to /makisu-internal/certs, which only contains a list of most common certs. I think as a result, all downloads get affected...

The correct use of /makisu-internal/certs is to append them to system certs (/etc/ssl/certs), which is what we do in makisu already.

Initially SSL_CERT_DIR was added to help cred helpers. I think it is okay to ask the users to pass it in if they want to point it to an alternative location.