Use ECR as go lib instead of the binary

uber-archive / makisu

Fast and flexible Docker image building tool, works in unprivileged containerized environments like Mesos and Kubernetes.

Apache License 2.0

2.41k stars 154 forks source link

Use ECR as go lib instead of the binary #222

Closed Rowern closed 5 years ago

Rowern commented 5 years ago

It might be possible to do the same with GCR but for now I don't have a google cloud account, I'm might be able to create one for this purpose but for now I tested ECR.

CLAassistant commented 5 years ago

All committers have signed the CLA.

Rowern commented 5 years ago

I have no way of testing GCR (even after doing the whole setup and loosing 2h with service accounts and their horrible IAM console...). If anyone is willing, could you just try this PR to validate that GCR is still working properly ?

EDIT: It was caused by a regression fixed by #223. GCR does work with this PR.

Rowern commented 5 years ago

Sorry for the push -f, now this is updated with latest master (so no more GCR auth bug)

evelynl94 commented 5 years ago

thank you for doing that!