uber-archive / makisu

Fast and flexible Docker image building tool, works in unprivileged containerized environments like Mesos and Kubernetes.
Apache License 2.0
2.41k stars 154 forks source link

set SSL_CERT_DIR to get gcr docker-credential-helper working #248

Open geekflyer opened 5 years ago

geekflyer commented 5 years ago

Adds SSL_CERT_DIR to the dockerfiles to make GCR credential helper working without extra work.

See also https://github.com/uber/makisu/issues/204#issuecomment-484111846

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

evelynl94 commented 5 years ago

LGTM, could you also add a few comments in the readme?