Closed antonsergeyev closed 4 years ago
This is also an issue that I am having!
This bug may lie inside the lib/parser/dockerfile/replace_variables.go
file but I might be mistaken.
I will take a look at this later this week.
EDIT: Not at all inside the replace_variables file.
It looks like docker create the following Entrypoint:
[
"/bin/sh",
"-c",
"echo ${MESSAGE}"
]
And makisu:
[
"echo",
"${MESSAGE}"
]
EDIT: A simple workaround until this is fixed is to use this syntax for the entrypoint: from the dockerfile ref
Anothre PR to handle the CMD
directive that also needs this mechanism: https://github.com/uber/makisu/pull/323
@yiranwang52 You can close this I think
Yes, thanks for fixing this.
Describe the bug An environment variable used in ENTRYPOINT is not substituted with its value at runtime.
To Reproduce Assume a dockerfile:
Build it with docker (works as expected):
Build it with makisu (unexpected output):
Expected behavior I expect ENTRYPOINT to change dynamically with respect to the environment variable. The output above should be "hello".
Additional context I'm using makisu 0.1.12 and docker 19.03.3