uber-archive / makisu

Fast and flexible Docker image building tool, works in unprivileged containerized environments like Mesos and Kubernetes.
Apache License 2.0
2.41k stars 153 forks source link

Allow for global ARG substitution between stages #325

Closed Rowern closed 4 years ago

Rowern commented 4 years ago

See: https://github.com/moby/moby/issues/37345#issuecomment-400245466

While doing this I saw that the entrypoint on the image is different than docker (from Dockerfile of testdata/build-context/global-arg/Dockerfile):
Docker:
if [ -z \"$version\" -a \"$version2\" = \"v2\" ]; then echo \"This is correct\"; exit 0; else exit 1; fi Makisu: if [ -z \"$version\" -a \"v2\" = \"v2\" ] ; then echo \"This is correct\" ; exit 0 ; else exit 1 ; fi

Makisu should not do substitution in the CMD and ENTRYPOINT directive (as seen in the list here: https://docs.docker.com/engine/reference/builder/#environment-replacement)

Rowern commented 4 years ago

Integration tests are failing until https://github.com/uber/makisu/pull/323 is merged. I need the fix on ENTRYPOINT PARSING.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

Rowern commented 4 years ago

CLA assistant check All committers have signed the CLA.

Weird that I had to sign this again...

Rowern commented 4 years ago

EDIT: I'm bad at integration testing  😅