search

uber-archive / multitransport-jsonrpc

JSON-RPC Client (Node.js & Browser) and Server (Node.js) aim at "natural looking" server and client code.
116 stars 22 forks source link

Return.on.request.error #39

Closed jwolski closed 10 years ago

jwolski commented 10 years ago

@dfellis This is the error I showed to you last week. On request error, response is undefined and we fall into both if conditions because we're not returning on error.

dfellis commented 10 years ago

Thanks! Can we add a test to prevent regressions? Something that causes response to be undefined and make sure the callback isn't called twice (and that nothing is thrown)?

jwolski commented 10 years ago

@dfellis Sure.

dfellis commented 10 years ago

Alright! Let's publish this. :)

coveralls commented 9 years ago

Coverage Status

Changes Unknown when pulling 8015b2f7484e8e53e081b55bdddb83a3871d7d7f on return.on.request.error into \ on master**.

dfellis commented 9 years ago

@coveralls lolwut, this is very eventual consistency.