search

uber-archive / multitransport-jsonrpc

JSON-RPC Client (Node.js & Browser) and Server (Node.js) aim at "natural looking" server and client code.
116 stars 22 forks source link

add error code for error response #52

Closed horiuchi closed 10 years ago

horiuchi commented 10 years ago

add error.code via. http://www.jsonrpc.org/specification#error_object

Raynos commented 10 years ago

:+1:

Raynos commented 10 years ago

travis 0.8 fails because it uses a lulzy npm version, need to npm i npm -g in before install in travis

horiuchi commented 10 years ago

the test of node v0.8 is required? i use and test v0.10 only.

Raynos commented 10 years ago

Yes we should still support 0.8

horiuchi commented 10 years ago

fix it.

Raynos commented 10 years ago

yay travis is happy :)

Raynos commented 10 years ago

this lgtm but i'll wait for @dfellis

horiuchi commented 10 years ago

Thank you for review!

dfellis commented 10 years ago

I'm merging it. Thank you very much @horiuchi :) Will publish shortly after and update in here when that's done.

dfellis commented 10 years ago

Published as 0.5.0 :)

horiuchi commented 10 years ago

:+1: