search

uber-archive / multitransport-jsonrpc

JSON-RPC Client (Node.js & Browser) and Server (Node.js) aim at "natural looking" server and client code.
116 stars 22 forks source link

Allow headers to be passed through in config #55

Closed brianstarke closed 10 years ago

brianstarke commented 10 years ago

I found this useful for adding in an Authorization header.

coveralls commented 10 years ago

Coverage Status

Coverage increased (+0.59%) when pulling 1576abd7c477fdcbc957084ca9663a56c27162e0 on brianstarke:master into f939d20ef88962001d357be1cc8bdb2fc7ee7af7 on uber:master.

dfellis commented 10 years ago

Looks good to me.

Can you add a simple unit test for this, making sure http.request gets the headers object, to make sure this never regresses in the future?

brianstarke commented 10 years ago

No problem.

brianstarke commented 10 years ago

Oops! Case of the Mondays.

On second thought, I just added these 2 assertions to the pre-existing unit test. Let me know if you think it's better as two test cases.

coveralls commented 10 years ago

Coverage Status

Coverage increased (+0.59%) when pulling 66efdd993669f9334a62293749495437a99c1576 on brianstarke:master into f939d20ef88962001d357be1cc8bdb2fc7ee7af7 on uber:master.

dfellis commented 10 years ago

Perfectly fine with that. :)

dfellis commented 10 years ago

Published as 0.7.0 in npm :)