If an HTTP jsonrpc server is down, the error doesn't get to the callback passed to the client method

uber-archive / multitransport-jsonrpc

JSON-RPC Client (Node.js & Browser) and Server (Node.js) aim at "natural looking" server and client code.

116 stars 22 forks source link

If an HTTP jsonrpc server is down, the error doesn't get to the callback passed to the client method #73

Open dughibot opened 8 years ago

dughibot commented 8 years ago

If the RPC server is down and an http client tries to make a request, the response from the http client is an Error object rather than an object with the field "error." This means that the error doesn't actually get properly returned to the callback.

I made a fix: https://github.com/uber/multitransport-jsonrpc/pull/72