[DNS recovery]: Bug fixes

uber-archive / node-statsd-client

Node.js client for statsd

ISC License

28 stars 9 forks source link

Closed Raynos closed 10 years ago

Raynos commented 10 years ago

we need to unref an interval otherwise its a breaking change. Previously statsd would not keep a process open.
we need to reset writePos, we forgot to do so and it's a bug that causes us to flush empty buffers accidentally.

cc @jcorbin @sh1mmer @Matt-Esch @kriskowal

sh1mmer commented 10 years ago

lgtm.

sh1mmer commented 10 years ago

Can we get a test for resets?

Raynos commented 10 years ago

Yes but as a seperate PR.