search

uber-archive / node-statsd-client

Node.js client for statsd
ISC License
28 stars 9 forks source link

[DNS recovery]: Remove timeout feature and replace with unref(). #6

Closed Raynos closed 10 years ago

Raynos commented 10 years ago

The EphemeralSocket had a timeout feature build into it so that the statsd client doesn't keep a CLI program open.

This was implemented in a complicated way with timers, I've removed that complexity and replaced it with an unref() call.

cc @sh1mmer @kriskowal

sh1mmer commented 10 years ago

This means that you recreate the socket (FD) lots of times instead of opening it and then reusing it until the timeout.

I'm not sure that's what you/we want.

Raynos commented 10 years ago

No. This means we create the socket once and never recycle it.

Previously it was recycled every second.

jcorbin commented 10 years ago

if it works, simpler is better

Raynos commented 10 years ago

Rebased.