search

uber-archive / ohana-ios

Contacts simplified. This project is deprecated and not maintained.
MIT License
362 stars 40 forks source link

Fixed header import that was causing incompatibility issues #13

Closed NickEntin closed 8 years ago

NickEntin commented 8 years ago

The use_frameworks! flag now works properly. Fixes #12.

maxwellE commented 8 years ago

@NickEntin is this good to land?

NickEntin commented 8 years ago

@maxwellE Yep, go for it!

NickEntin commented 8 years ago

@maxwellE This could potentially be a breaking change considering the pods config changed, but I think major is enough since API-wise it's the same. Up to you.

NickEntin commented 8 years ago

The important change is in OHPhoneNumberFormattingPostProcessor.m. The other changes are in moving the example app over to frameworks and updating the pod version.

// This imports libPhoneNumber-iOS if using libraries
#if __has_include(<libPhoneNumber-iOS/NBPhoneNumberUtil.h>)
  #import <libPhoneNumber-iOS/NBPhoneNumberUtil.h>
#endif

// This imports libPhoneNumber-iOS if using frameworks
#if __has_include(<libPhoneNumber_iOS/NBPhoneNumberUtil.h>)
  #import <libPhoneNumber_iOS/NBPhoneNumberUtil.h>
#endif
NickEntin commented 8 years ago

@maxwellE Can you land this?