search

uber-archive / r-dom

React DOM wrapper
MIT License
263 stars 18 forks source link

Initial version #1

Closed mlmorg closed 9 years ago

mlmorg commented 9 years ago

cc @cain-uber

Raynos commented 9 years ago

lgtm.

cain-wang commented 9 years ago

Hi Matt,

Awesome! Thanks for setting up the ground work. I had some prototype code running, shall I post a code review and we could discuss it?

Thanks,

Cain

On Sun, Dec 21, 2014 at 6:08 PM, Matt Morgan notifications@github.com wrote:

cc @cain-uber https://github.com/cain-uber

You can merge this Pull Request by running

git pull https://github.com/uber/r-dom dev/initial

Or view, comment on, or merge it at:

https://github.com/uber/r-dom/pull/1 Commit Summary

  • Get basic tag working
  • Add a bunch of tests and get them working
  • Add a bunch of tests for components
  • Add more tests
  • Change name of file
  • Add more key property tests
  • Change test name
  • More test changes
  • Get ready for shipping
  • Add readme

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/uber/r-dom/pull/1.

mlmorg commented 9 years ago

Do you want me to merge this first?

cain-wang commented 9 years ago

Oh, I just found out somehow github rejected my review comments earlier .. I'll just post it here.

I noticed we are having the children passed in as an array into r(), React.createElement() just assumes whatever follows the attribute config are child elements, I think that provides a cleaner syntax.

Thanks,

Cain