uber-archive / r-dom

React DOM wrapper
MIT License
263 stars 18 forks source link

simplify classSet logic #28

Closed chrisirhc closed 8 years ago

chrisirhc commented 9 years ago

Remove a loop. className can be treated as a class itself.

chrisirhc commented 9 years ago

I don't think anybody should be relying on behavior on duplicate / de-duplicated classes though. Since it doesn't affect any behavior in the browser. The behavior is also inconsistent when there's multiple classes in a key in classSet.

But you're right, this does affect people who do rely on such (imho brittle) behavior.

chrisirhc commented 9 years ago

Simplified further thanks to @clanam .

dawsbot commented 8 years ago

Closing since this is stale. Feel free to re-open if this is still relevant and we can re-investigate.