Fix samples that cannot run properly - Githubissues

uber-common / cadence-samples

Other

191 stars 92 forks source link

Fix samples that cannot run properly #46

Closed calvinxiao closed 2 years ago

calvinxiao commented 3 years ago

1. Use `h.StartWorkers` to start worker

When code uses worker.New to create worker, it forgot to register workflows and activities, causing workers not responding to any triggers

Changed samples:

choice
mutex
pickfirst

2. Makefile is missing some sample builds

cancelactivity
sideeffect

3. Remove workflow and activity registering code in `func init()`

it caused ... is already registered panic.

samples/recovery

CLAassistant commented 3 years ago

All committers have signed the CLA.