search

uber-common / jvm-profiler

JVM Profiler Sending Metrics to Kafka, Console Output or Custom Reporter
Other
1.78k stars 342 forks source link

[Feature] Adding ThreadMXBean information in the profiler #Issue52 #80

Closed rahul26goyal closed 3 years ago

rahul26goyal commented 3 years ago

As per the discussion on https://github.com/uber-common/jvm-profiler/issues/52, adding Support for Collecting Some stats related to JVM Threads.

  1. A new Profiler called ThreadInfoProfiler is added which makes use of ThreadMXBean to Collect and report the Stats.
  2. Unit Tests for the same are added.

The Metric Looks like the following:

ConsoleOutputReporter - ThreadInfo: {"liveThreadCount":6,"appId":null,"name":"52769@MacBook-Pro.local","host":"MacBook-Pro.local","processUuid":"923a1e00-1413-4fd5-800b-08764ea1faaf","totalThreadCount":6,"epochMillis":1601806705706,"tag":"mytag","peakThreadCount":6,"newThreadCount":0}

Please review and let me know if I have missed anything.

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: rahul26goyal
:x: Rahul Goyal

Rahul Goyal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

rahul26goyal commented 3 years ago

Need to decline this PR as there was an issue with the user.email used for committing. Created a new one: https://github.com/uber-common/jvm-profiler/pull/81