uber-common / jvm-profiler

JVM Profiler Sending Metrics to Kafka, Console Output or Custom Reporter
Other
1.79k stars 342 forks source link

RollingFileOutputReporter support #87

Closed V1ncentzzZ closed 3 years ago

V1ncentzzZ commented 3 years ago

Hi, I hava an idea like the titile. Because the file is not allowed to keep growing in streaming jobs. So we hava to use rolling file for it. What do you think?

hiboyang commented 3 years ago

Yes, this is a great idea!

V1ncentzzZ commented 3 years ago

Can i contribute to this? @hiboyang I will try to implement it if we need.

hiboyang commented 3 years ago

Yes, your contribution will be great! Thanks!

vectorijk commented 3 years ago

close the issue as PR #88 is merged. feel free to reopen if needed