Support rolling mode in `FileOutputReporter`

uber-common / jvm-profiler

JVM Profiler Sending Metrics to Kafka, Console Output or Custom Reporter

Other

1.78k stars 342 forks source link

Support rolling mode in `FileOutputReporter` #88

Closed V1ncentzzZ closed 3 years ago

V1ncentzzZ commented 3 years ago

Support rolling mode in FileOutputReporter.

CLAassistant commented 3 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

xiaozilong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

V1ncentzzZ commented 3 years ago

Hi @hiboyang , Would you help reivew this?

hiboyang commented 3 years ago

Hi @hiboyang , Would you help reivew this?

I am not in Uber anymore, @vectorijk, do you want to take a look at this PR?

V1ncentzzZ commented 3 years ago

Hi @vectorijk , What should i do for next？

vectorijk commented 3 years ago

Merged your PR. @V1ncentzzZ Thanks for the contribution!