search

uber-common / jvm-profiler

JVM Profiler Sending Metrics to Kafka, Console Output or Custom Reporter
Other
1.79k stars 342 forks source link

[Feature] Support reload class when use VirtualMachine#loadAgent #95

Closed leozhiyu closed 3 years ago

leozhiyu commented 3 years ago

My Test Evidence

Test Steps

  1. Create a test class to dynamic attach target process. eg, RunAttachProfiler.java
  2. Run HelloWorldApplication class.
  3. Update process id in RunAttachProfiler.java and run RunAttachProfiler class.
  4. We can see the result in the picture below.

Before my modification, i can not see the result.

image

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

leozhiyu commented 3 years ago

Hi @vectorijk , Would you help review this?

leozhiyu commented 3 years ago

Hi @CodingCat, would you help review this?

leozhiyu commented 3 years ago

Hi @hiboyang , Would you help review this?

hiboyang commented 3 years ago

Hi @hiboyang , Would you help review this?

This is a great feature! Thanks for adding it! I do not work in Uber anymore. Maybe @vectorijk could help to review and merge?

vectorijk commented 3 years ago

lgtm. @leozhiyu thanks for your contribution!