Improve support for Boto 3

uber-common / opentracing-python-instrumentation

A collection of Python instrumentation tools for the OpenTracing API

MIT License

164 stars 58 forks source link

Improve support for Boto 3 #102

Closed Jamim closed 5 years ago

Jamim commented 5 years ago

Hello @yurishkuro,

This PR adds support for Boto 3 clients including enhanced support for the S3 client.

These changes also:

replace amazon/dynamodb-local docker image with localstack/localstack docker image for tests
fix test for SQLAlchemy

Related issue: #101

coveralls commented 5 years ago

Coverage increased (+0.6%) to 84.719% when pulling a707bbcec1049d35bd0b28f347acf7091f23e93a on Jamim:feature/improve-boto3-support into 79c692fc522b52feb557c6d775a9f59bfdeef45c on uber-common:master.

Jamim commented 5 years ago

Hello @yurishkuro, Could you please review this PR? Thank you!

yurishkuro commented 5 years ago

Related issue: #101

Is this fixing it? If so, please update description to Resolves #101.

Jamim commented 5 years ago

Hello @yurishkuro,

I'm not quite sure that this PR resolves #101 completely since @berkowitzi was asking for some example snippets. I'm going to publish them once the updated version of this library is available. So I propose to keep #101 open and wait for @berkowitzi to confirm that everything is fine.

Thanks!

yurishkuro commented 4 years ago

@Jamim are you aware of any new/recent issues in Travis for dynamodb? The builds are hanging, e.g. https://travis-ci.org/github/uber-common/opentracing-python-instrumentation/jobs/699073221