Refactor SQLAlchemy hook

uber-common / opentracing-python-instrumentation

A collection of Python instrumentation tools for the OpenTracing API

MIT License

164 stars 58 forks source link

Refactor SQLAlchemy hook #98

Closed Jamim closed 5 years ago

Jamim commented 5 years ago

Hello @yurishkuro,

I hope you'll find this PR useful.

These changes also:

Add a basic test for the SQLAlchemy hook
Clean up boilerplate code

Best regards!

coveralls commented 5 years ago

Coverage increased (+2.6%) to 82.889% when pulling 0bc2ec76ece549f0ab2d6684d28a8d162e35f3fb on Jamim:feature/refactor-sqlalchemy-hook into 86791edfec15461dd1132f2f253fd2560ed11bbf on uber-common:master.

Jamim commented 5 years ago

Hi @yurishkuro, Do you have any other suggestions?