Closed seriousben closed 3 years ago
What changed? Adding the missing interceptors in the workflow context sent to child workflow mocks.
Why? To support calling workflow.GetInfo(ctx) within mocks without a panic.
workflow.GetInfo(ctx)
This is a regression introduced in 0.12.2 as part of adding interceptor support.
How did you test it?
Unit test failure before the fix:
panic: getWorkflowInterceptor: Not a workflow context goroutine 47 [running]: go.uber.org/cadence/internal.getWorkflowInterceptor(...) cadence-client/internal/internal_workflow.go:288 go.uber.org/cadence/internal.GetWorkflowInfo(0x1aec9c0, 0xc0004fe000, 0xc0004fe000) cadence-client/internal/workflow.go:756 +0xce go.uber.org/cadence/internal.(*WorkflowTestSuiteUnitTest).Test_ChildWorkflow_Mock.func2(0xc00007ed80, 0x3, 0x4) cadence-client/internal/internal_workflow_testsuite_test.go:728 +0x7d
Potential risks No risk since only changing the testsuite.
What changed? Adding the missing interceptors in the workflow context sent to child workflow mocks.
Why? To support calling
workflow.GetInfo(ctx)
within mocks without a panic.This is a regression introduced in 0.12.2 as part of adding interceptor support.
How did you test it?
Unit test failure before the fix:
Potential risks No risk since only changing the testsuite.