Minor test enhancement for local activity retries

uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.

https://cadenceworkflow.io

MIT License

345 stars 131 forks source link

Minor test enhancement for local activity retries #1069

Closed Groxx closed 3 years ago

Groxx commented 3 years ago

While looking into a user's issue with local activities retrying and not seeming to honor NonRetriableErrorReasons, I noticed that we had no tests for non-retriable local activity errors.

So this test now mimics Test_ActivityRetry, but with local activities and maybe better names. No problems found.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 5b6b0771-6ecf-43fb-85ec-1f0c614506a3

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 75.674%

Totals
Change from base Build f4cc69d4-9683-48eb-aaa1-f4ed109a91cc:	0.01%
Covered Lines:	10132
Relevant Lines:	13389

uber-go / cadence-client

Minor test enhancement for local activity retries #1069

Pull Request Test Coverage Report for Build 5b6b0771-6ecf-43fb-85ec-1f0c614506a3

💛 - Coveralls