uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
345 stars 131 forks source link

[grpc] Duplicate metrics api wrapper #1102

Closed vytautas-karpavicius closed 3 years ago

vytautas-karpavicius commented 3 years ago

What changed? This is a copy of internal/common/metrics/service_wrapper_test.go that is wrapping on api.Interface instead of generated Thrift interface. This is necessary, as both interfaces will co-exist during the conversion period. After that, the old one will be removed.

Why? GRPC migration

How did you test it?

Potential risks

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 2af79503-082f-4623-85d6-97d06fe26cbb


Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/common/metrics/api_wrapper.go 169 256 66.02%
<!-- Total: 169 256 66.02% -->
Files with Coverage Reduction New Missed Lines %
internal/internal_task_pollers.go 10 80.44%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 7182f214-695d-4a48-95b4-e1d9a583d4a0: -0.2%
Covered Lines: 10576
Relevant Lines: 14525

💛 - Coveralls