search

uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
345 stars 131 forks source link

0.17.0 Thrift Error #1107

Open ding1992 opened 3 years ago

ding1992 commented 3 years ago

Describe the bug Code compatibility issue with thrift 0.13.0

To Reproduce Is the issue reproducible? Yes

Steps to reproduce the behavior: go get go.uber.org/cadence@v0.17.0

Expected behavior No error

Actual behavior

../../../../pkg/mod/go.uber.org/cadence@v0.17.0/internal/common/thrift_util.go:31:38: not enough arguments in call to thrift.NewTSerializer().Write have (thrift.TStruct) want (context.Context, thrift.TStruct) ../../../../pkg/mod/go.uber.org/cadence@v0.17.0/internal/common/thrift_util.go:47:18: not enough arguments in call to v.Write have (thrift.TProtocol) want (context.Context, thrift.TProtocol) ../../../../pkg/mod/go.uber.org/cadence@v0.17.0/internal/common/thrift_util.go:53:27: not enough arguments in call to t.Protocol.Flush have () want (context.Context) ../../../../pkg/mod/go.uber.org/cadence@v0.17.0/internal/common/thrift_util.go:57:28: not enough arguments in call to t.Transport.Flush have () want (context.Context) ../../../../pkg/mod/go.uber.org/cadence@v0.17.0/internal/common/thrift_util.go:67:39: not enough arguments in call to thrift.NewTDeserializer().Read have (thrift.TStruct, []byte) want (context.Context, thrift.TStruct, []byte) ../../../../pkg/mod/go.uber.org/cadence@v0.17.0/internal/common/thrift_util.go:79:21: not enough arguments in call to ts[i].Read have (thrift.TProtocol) want (context.Context, thrift.TProtocol)

KScaesar commented 3 years ago

I have the same problem How do I solve this?

My version go version go1.16.4 linux/amd64

longquanzheng commented 2 years ago

See @Groxx comment https://github.com/uber-go/cadence-client/issues/1129#issuecomment-932554933

longquanzheng commented 2 years ago

Make sure you use the right version of thrift

Thrift 0.9.3 (use homebrew or distribution)

longquanzheng commented 2 years ago

You can pin the thrift version: like this: https://github.com/uber/cadence/blob/d3d06825adcf11c20ec3fc58e329f1d9560bb729/go.mod#L92