uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
345 stars 131 forks source link

Compatibility layer fix #1120

Closed vytautas-karpavicius closed 3 years ago

vytautas-karpavicius commented 3 years ago

What changed? Fixed protoUpdateDomainRequest in compatibility layer.

Why? Previously it was not handling intermediate nil structures.

How did you test it? Added additional integration test to cover domain update operation.

Potential risks

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build da3507f7-9f1a-4c20-93b2-b04f07f57e99


Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/compatibility/request.go 9 47 19.15%
<!-- Total: 9 47 19.15% -->
Totals Coverage Status
Change from base Build e21f62c8-7503-4e4c-9804-603fcab8073e: 0.5%
Covered Lines: 12151
Relevant Lines: 16983

💛 - Coveralls