fix 0.18.4 - Githubissues

Groxx commented 2 years ago

Compatibility layer fix (#1120)
Clear workflow state when not cached and not complete (#1111)
Minor cleanup (#1106)
Bump yarpc to 1.55.0 (#1110)
Use the same timer duration validation with server (#1121)
Add documentation for Selector (#1115)
Close the test dispatcher when completing (#1117)
Fix client side race condition (#1124)
Improve check for invalid pollForDecisionTaskResponse (#1122)
Add DecisionTaskStartedEventID to workflowInfo (#1127)
Filling out Selector docs, and some adjacent ones I noticed (#1131)
Enhancing docs for selector and channel, from feedback and careful testing (#1137)
Fix childWF decision panic after reset due to runID change (#1118)
Add a random UUID to worker identities, to prevent collisions (#1135)
Added 2-way proto-thrift mapper (#1130)
Fix TestQueryTask_WorkflowCacheEvicted (#1140)
Fix parent vs child race (#1141)
Creating cadence.IsWorkflowError helper (#1145)
New docs section for canceled-context in workflows, other minor cleanups (#1134)
Demonstrate ExecuteChildWorkflow bug + prepare test for a fix
Implement bugfix for child-workflow bug in #1138
"Backported" un-bugfix in case people hit non-determinism errors
Bump cadence.Version to 0.18.4 (#1146)
Revert "Added 2-way proto-thrift mapper (#1130)"
fmt, removing globals from tests, scoping test logs (#1142)

What changed?

Why?

How did you test it?

Potential risks

Groxx commented 2 years ago

compared to wrong branch

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 5118d85f-4c62-46a4-a6de-d81314e82248

147 of 221 (66.52%) changed or added relevant lines in 13 files are covered.
814 unchanged lines in 16 files lost coverage.
Overall coverage increased (+8.0%) to 71.257%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/context.go	31	32	96.88%
internal/session.go	0	1	0.0%
mocks/Client.go	0	1	0.0%
internal/internal_event_handlers.go	12	15	80.0%
internal/internal_worker.go	15	19	78.95%
client/client.go	24	34	70.59%
internal/workflow.go	24	40	60.0%
internal/compatibility/request.go	9	47	19.15%
<!--	Total:	147	221	66.52%	-->

Files with Coverage Reduction	New Missed Lines	%
client/client.go	2	71.74%
internal/common/convert.go	3	84.62%
internal/client.go	12	87.63%
internal/context.go	16	84.0%
internal/worker.go	16	15.79%
internal/internal_utils.go	20	85.41%
worker/worker.go	27	18.18%
workflow/workflow.go	30	47.37%
internal/compatibility/adapter.go	33	43.23%
internal/internal_task_pollers.go	39	81.53%
<!--	Total:	814	-->

Totals
Change from base Build 4f32e7fd-8f48-4ad7-9dd0-cf6c681c5e48:	8.0%
Covered Lines:	11907
Relevant Lines:	16710