coveralls
commented
2 years ago Pull Request Test Coverage Report for Build b899fa80-3fcd-49ed-94bd-61b3ad60e9f9
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 5 unchanged lines in 2 files lost coverage.
- Overall coverage decreased (-0.03%) to 63.27%
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| internal/internal_task_pollers.go | 2 | 81.53% | ||
| internal/common/convert.go | 3 | 84.62% | ||
| <!-- | Total: | 5 | --> |
| Totals | |
|---|---|
| Change from base Build 4f32e7fd-8f48-4ad7-9dd0-cf6c681c5e48: | -0.03% |
| Covered Lines: | 12251 |
| Relevant Lines: | 19363 |
What changed?
go get github.com/uber/cadence-idlgo.uber.org/cadence/.gen/proto/api/v1withgithub.com/uber/cadence-idl/go/proto/api/v1everywhereWhy? Public API proto types are generated on cadence-idl repo (https://github.com/uber/cadence-idl/pull/94) so that they could be shared between client/server. Otherwise it results in duplicated type registrations when using both.
How did you test it?
Potential risks Unfortunately this is a BREAKING CHANGE for people that started using
compatibilitypackage. Good thing is that fix is easy - replace one import pathgo.uber.org/cadence/.gen/proto/api/v1->github.com/uber/cadence-idl/go/proto/api/v1Will need to mention this in the change log of the next release.