uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
344 stars 130 forks source link

Upgrade x/sys and quantile to work with Go 1.18 #1164

Closed Groxx closed 2 years ago

Groxx commented 2 years ago

Builds with 1.18 are currently failing with numerous errors like:

> make bins
go build -o .build/dummy internal/cmd/dummy/dummy.go
# golang.org/x/sys/unix
../../../pkg/mod/golang.org/x/sys@v0.0.0-20200930185726-fdedc70b468f/unix/syscall_darwin.1_13.go:29:3: //go:linkname must refer to declared function or variable
../../../pkg/mod/golang.org/x/sys@v0.0.0-20200930185726-fdedc70b468f/unix/zsyscall_darwin_amd64.1_13.go:27:3: //go:linkname must refer to declared function or variable

This is pretty easily addressed with go get -u go.lang.org/x/sys, which (plus make build to verify) is all this commit would contain...

... but github.com/streadway/quantile was using a import ".", which apparently Go 1.18 disallows for modules. Which breaks go mod tidy rather awkwardly. TIL. Now that https://github.com/streadway/quantile/pull/8 is merged though, the new master works, so that has been updated as well.


Previously:

It would probably be good to upgrade other things and do a go mod tidy, but unfortunately that is currently failing with:

go.uber.org/cadence/internal imports
    go.uber.org/yarpc imports
    github.com/uber/tchannel-go tested by
    github.com/uber/tchannel-go.test imports
    github.com/streadway/quantile tested by
    github.com/streadway/quantile.test imports
    .: "." is relative, but relative import paths are not supported in module mode

I've opened a PR for the core fix: https://github.com/streadway/quantile/pull/8 And I've asked yarpc/tchannel internally to see if they can address this as well, as I'm really not sure how long that will take to merge.

In the meantime, as far as I can tell, we just can't do go mod tidy. Updating / installing / etc of dependencies works fine.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1175e832-e9e9-4c97-864d-74cc1082a4d7


Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/compatibility/adapter.go 0 1 0.0%
internal/common/auth/service_wrapper.go 0 2 0.0%
internal/compatibility/proto/request.go 0 2 0.0%
<!-- Total: 0 5 0.0% -->
Files with Coverage Reduction New Missed Lines %
internal/internal_task_pollers.go 2 81.64%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 2db1895d-7a68-425d-b16f-1dd9cce48c62: 0.07%
Covered Lines: 12385
Relevant Lines: 19427

💛 - Coveralls