Closed Groxx closed 2 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
internal/compatibility/adapter.go | 0 | 1 | 0.0% | ||
internal/common/auth/service_wrapper.go | 0 | 2 | 0.0% | ||
internal/compatibility/proto/request.go | 0 | 2 | 0.0% | ||
<!-- | Total: | 0 | 5 | 0.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
internal/internal_task_pollers.go | 2 | 81.64% | ||
<!-- | Total: | 2 | --> |
Totals | |
---|---|
Change from base Build 2db1895d-7a68-425d-b16f-1dd9cce48c62: | 0.07% |
Covered Lines: | 12385 |
Relevant Lines: | 19427 |
Builds with 1.18 are currently failing with numerous errors like:
This is pretty easily addressed with
go get -u go.lang.org/x/sys
, which (plusmake build
to verify) is all this commit would contain...... but github.com/streadway/quantile was using a
import "."
, which apparently Go 1.18 disallows for modules. Which breaksgo mod tidy
rather awkwardly. TIL. Now that https://github.com/streadway/quantile/pull/8 is merged though, the newmaster
works, so that has been updated as well.Previously:
It would probably be good to upgrade other things and do a
go mod tidy
, but unfortunately that is currently failing with:I've opened a PR for the core fix: https://github.com/streadway/quantile/pull/8 And I've asked yarpc/tchannel internally to see if they can address this as well, as I'm really not sure how long that will take to merge.
In the meantime, as far as I can tell, we just can't do
go mod tidy
. Updating / installing / etc of dependencies works fine.