search

uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
344 stars 130 forks source link

Do not retry on LimitExceededError #1170

Closed mantas-sidlauskas closed 2 years ago

mantas-sidlauskas commented 2 years ago

What changed? Mark LimitExceededError as non transient error

Why? There's no need to retry signal operation as error will not go away eventually

How did you test it? Unit test

Potential risks

davidporter-id-au commented 2 years ago

I reckon the limitExceeded error fix is probably semi-urgent I now realise (apologies for missing it before). Maybe we can just merge in this fix and Steven's larger one can happen after?