uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
344 stars 130 forks source link

Simplify worker options configuration value propagation #1179

Closed shijiesheng closed 2 years ago

shijiesheng commented 2 years ago

What changed?

use embedding to simplify assignment

Why?

There are duplicate fields in workerExecutionParameters and WorkerOptions that unnecessarily complicates the logic.

How did you test it?

Potential risks

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 018202cd-3766-4fe6-9a85-eb08cbef7e97


Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/internal_worker.go 10 12 83.33%
<!-- Total: 28 30 93.33% -->
Files with Coverage Reduction New Missed Lines %
internal/internal_worker.go 1 84.21%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 0181b24f-c812-4399-b98d-d8f07b90e9dd: -0.04%
Covered Lines: 12423
Relevant Lines: 19446

💛 - Coveralls