uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
344 stars 130 forks source link

MethodRetry - maximumAttempts is a Required Parameter #1190

Closed bw-abrowne closed 1 year ago

bw-abrowne commented 1 year ago

Describe the bug An IllegalArgumentException occurs if maximumAttempts is not passed for an activity's MethodRetry

To Reproduce Is the issue reproducible?

Steps to reproduce the behavior: Don't pass maximumAttempts; seen when initialIntervalSeconds, backoffCoefficient, maximumIntervalSeconds, and expirationSeconds are all populated.

Expected behavior The default value of maximumAttempts (0) should be used and an IllegalArgumentException should not be thrown.

Additional context Additionally, the concepts documentation includes inconsistent parameter names as compared to the Java client