uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
344 stars 130 forks source link

Revert "Upgrade tally to v4 (fixes uber-go/cadence-client#1157) (#1168)" #1191

Closed shijiesheng closed 1 year ago

shijiesheng commented 1 year ago

This reverts commit 2f2932914f7beff3961fcd3066acd82b75b4d2dc.

What changed?

Revert the tally upgrade. This is a breaking change indicated here https://github.com/uber-go/cadence-client/pull/1168#issuecomment-1182294031

Why?

How did you test it?

Potential risks

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 01838048-049e-43b2-88bc-13defe5b2a4b


Files with Coverage Reduction New Missed Lines %
internal/compatibility/thrift/history.go 11 57.72%
<!-- Total: 11 -->
Totals Coverage Status
Change from base Build 01836234-f62a-40d8-8f83-692059a063ba: 0.06%
Covered Lines: 12598
Relevant Lines: 19637

💛 - Coveralls