ran "make fmt"

[mindaugasbarcauskas]

What changed?

Just ran "make fmt" so that files are formatted correctly.

Why?

These changes come in when running "make build" and interfere when making changes.

How did you test it? Should be no functional impact.

Potential risks Not applicable.

[Groxx]

We should probably:

• make sure our docker containers' version of Go is updated, if we have any that are doing a build and looking for changes (iirc we have that on server, I forget about client)
• bake in the same kind of go version check as server has: https://github.com/uber/cadence/blob/master/Makefile#L31
• make sure you've done fmt with that version of Go

I'm assuming you did this with 1.19, but double check? >=1.19 and <1.19 produce different output, which is the underlying issue you're hitting.

[mindaugasbarcauskas]

I did it with 1.19 go version. Yeah I was wondering if gofmt might depend on local configuration. I will check on those points. Thanks Steven.

[Groxx]

I did it with 1.19 go version. Yeah I was wondering if gofmt might depend on local configuration. I will check on those points. Thanks Steven.

Normally it doesn't, but 1.19 made (good!) enhancements to godoc's capabilities and formatting... and unfortunately it thrashes with older versions :| Historically they've been fairly careful to make changes that are backwards compatible, but not this time.

[coveralls]

Pull Request Test Coverage Report for Build 0185cb28-c2f3-49da-893b-efb14a042da2

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 13 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.06%) to 64.242%

---

Files with Coverage Reduction	New Missed Lines	%
internal/compatibility/thrift/enum.go	4	21.2%
internal/compatibility/thrift/types.go	9	48.42%
<!--	Total:	13		-->

Totals
Change from base Build 0185c943-fd48-4b30-94dd-4bd415ff8817:	-0.06%
Covered Lines:	12684
Relevant Lines:	19744

---

💛 - Coveralls