search

uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
345 stars 131 forks source link

updating cadence-idl version #1207

Closed mindaugasbarcauskas closed 1 year ago

mindaugasbarcauskas commented 1 year ago

What changed? Updated cadence-idl version.

note currently targeting ran-make-fmt branch since it is not merged yet.

Why?

Will need to use latest cadence-idl version for other story.

How did you test it?

Existing tests.

Potential risks

davidporter-id-au commented 1 year ago

Looks like we need to fix this up a bit :


# go.uber.org/cadence/internal/compatibility
--
  | internal/compatibility/adapter.go:47: cannot use thrift2protoAdapter{...} (type thrift2protoAdapter) as type workflowserviceclient.Interface in return argument:
  | thrift2protoAdapter does not implement workflowserviceclient.Interface (missing RestartWorkflowExecution method)
  | FAIL    go.uber.org/cadence/test [build failed]
  | FAIL
mindaugasbarcauskas commented 1 year ago

closing this one will open new one.