Making cancelWorkflow call extendable with options.

uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.

https://cadenceworkflow.io

MIT License

339 stars 128 forks source link

Making cancelWorkflow call extendable with options. #1208

Closed mindaugasbarcauskas closed 1 year ago

mindaugasbarcauskas commented 1 year ago

What changed?

Adding ability to provide workflow cancel reason by making cancelWorkflow call extendable with options. note: targeting updated-idl branch since those changes are not merged yet and it is stacked on top of that.

Why?

How did you test it? Added unit tests.

Potential risks

Groxx commented 1 year ago

Covered IRL, but to tl;dr:

yea, we've been breaking APIs in pre-release for a while, this is a rather minor one (and most code should upgrade transparently). let's merge it.
no func closures for functional options, they're far too problematic. just use a regular type and a privately-implementing interface.

mindaugasbarcauskas commented 1 year ago

closing created a different pull request