uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
345 stars 131 forks source link

Merged the timeout logic for the tests in internal_workers_test.go #1225

Closed jakobht closed 1 year ago

jakobht commented 1 year ago

What changed? I have merged the timeout logic for the tests in internal_workers_test, this raises the timeout to 10s for all tests, and treats timing out as a test failure.

Why? The tests were flaky, sometimes timing out sometimes not, also it was hard to find the reason they failed as timing out was not treated as a failure.

How did you test it? I ran all unit tests, this only changes the structure of the tests.

Potential risks This only changes the structure of the tests so it should not pose any risks.