Closed davidporter-id-au closed 1 year ago
broadly: might be some stuff to clean up, but structurally sound I think. we already have wrappers, one more for another optional feature seems fine.
I'm not all that sold on these wrappers to begin with, but they're already here ¯_(ツ)_/¯
I'm not going to investigate codegen in this PR, though it certainly feel's like it should have it at this point. Cleaned up the test though
What changed?
Why?
How did you test it?
Potential risks