uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
339 stars 128 forks source link

Adding WorkflowType to "Workflow panic" log-message #1258

Closed dkrotx closed 1 year ago

dkrotx commented 1 year ago

It is very expected to have this field, but customers have to walk through the stack trace, which is not always convinient especially with wrappers.

What changed? WorkflowType is logged among other fields in "Workflow panic" log-message.

Why? Seeing this field makes debugging easier. Especially when you have a log-view (Like Kibana or uMonitor) - you can add WorkflowType field as a column.

How did you test it? Verified by writing a workflow that panics + with the unit-test

Potential risks No risks - retrieving workflow-name is lock-free, and at least returns an empty string.