search

uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
339 stars 128 forks source link

Only log failed heartbeats if the error is not CanceledError #1271

Closed jakobht closed 9 months ago

jakobht commented 9 months ago

We now log when the automatic heartbeating fails introduced in #1263

What changed? We introduced this log to help stakeholders debug, however now stakeholders are being flooded with this log, lowering the log level so only logging when the error is not CanceledError.

Why? Lowered to avoid stakeholders who cancel workflows being flooded with error logs

How did you test it?

Potential risks No risk

dkrotx commented 9 months ago

I wonder, if it is a matter of cancelled workflow - is it possible to avoid logging when we know it is cancelled (we should know)?

jakobht commented 9 months ago

Changed so we now check if the error is a canceledError, in that case we do not log, otherwise we keep the error log